-
Notifications
You must be signed in to change notification settings - Fork 730
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Hardcoded Color for Button Hover State in QuizStatus.vue
#12645
Remove Hardcoded Color for Button Hover State in QuizStatus.vue
#12645
Conversation
Build Artifacts
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested it locally and the hover color works & looks great! Thanks for this!
@@ -349,7 +349,7 @@ | |||
// palette.red.v_1100 is the darkest available red | |||
// in the palette. Using this hardcoded color was |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would you remove this whole comment before we merge? It's not needed anymore, as $darken
is now supported and documented technique.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@MisRob , please check it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, all good :)!
Thanks @shivam-daksh and @nucleogenesis! |
Summary
This PR removes the hardcoded hover background color in the
QuizStatus.vue
component and replaces it with a dynamic color using the new$darken
utility functions provided by the Kolibri Design System....
Context:
The hover background color for buttons in the
QuizStatus.vue
component was previously hardcoded (#A81700
). This approach reduces flexibility and maintainability, especially when applying theme variations. To address this, the newly implemented$darken
utilities ($darken1
,$darken2
,$darken3
) will be used to generate a darker shade of the base red color, ensuring consistent theming throughout the UI.Code Changes:
#A81700
.$darken1
utility to derive the hover color dynamically based on the existing red color ($themePalette.red.v_1100
).Example of the changes made:
…
References
#12553
…
Reviewer guidance
…
Testing checklist
PR process
Reviewer checklist
yarn
andpip
)